search

afonsof / jenkins-material-theme

Beautify your Jenkins with the Material Design theme!
http://afonsof.com/jenkins-material-theme
MIT License
1.72k stars 355 forks source link

BUG - Console font is not Roboto Mono anymore #191

Open ylacaute opened 3 years ago

ylacaute commented 3 years ago

The material theme do not use Roboto Mono anymore for the console (as the result it breaks my beautiful ascii arts haha)

The problem comes from here :

:not(div.ace_editor) {
    font-family: Roboto,sans-serif !important;
    outline: 0;
}

If we remove !important, it is working If we replace Roboto by Roboto Mono, it is working

I did'nt tested in a real Jenkins, but I think Roboto should be Roboto Mono, => PR 190

senthil13 commented 3 years ago

+1, I am also facing the issue. but I would prefer removing the !important method. changing Roboto to Roboto Mono caused all fonts to change, but the first one only change the console output.

Thanks Senthil.

ylacaute commented 2 years ago

Indeed ! In fact we need to remove !important at 2 places :

#main-panel > pre {
    font-family: Roboto Mono,monospace !important;
}

:not(div.ace_editor) {
    font-family: Roboto,sans-serif !important;
    outline: 0;
}

We can guess this !important has been added for reason, it is then complicated to do a PR.

You can see the result with this : https://github.com/ylacaute/jenkins-material-theme-blue-grey-fixed (personally I don't really see any difference, excepted the console is now monospace which is very important)