afonsof / jenkins-material-theme

Beautify your Jenkins with the Material Design theme!
http://afonsof.com/jenkins-material-theme
MIT License
1.72k stars 356 forks source link

Breaks pipeline plugin #48

Open owenhaynes opened 8 years ago

owenhaynes commented 8 years ago

When applying this theme it breaks the pipeline(workflow) plugin editor box with its auto completion.

afonsof commented 8 years ago

Thanks a lot for filing this issue! I've reproduces your problem: image

Would you like to write a patch for this? We'd be more than happy to walk you through the steps involved.

stackfull commented 8 years ago

I had this issue and had to remove the font-family applied to all elements. This broke a few cases where the font should have been changed, but it did enable the pipeline editting again.

diff --git a/less/style.less b/less/style.less
index cf190a4..6deecb4 100644
--- a/less/style.less
+++ b/less/style.less
@@ -4,10 +4,6 @@
 @import '../node_modules/jenkins-core-theme/less/codemirror';
 @import url(https://fonts.googleapis.com/css?family=Roboto:400,700,500,300);

-* {
-  font-family: 'Roboto', sans-serif !important;
-}
-
 body, table, form, td, th, p {
   color: @color-text !important;
 }
go2sh commented 8 years ago

The Issue still persists... Copy the code into a PR?

afonsof commented 8 years ago

Sorry guys, I'll fix this asap

afonsof commented 8 years ago

The pasted diff string does not fix the problem. We cannot remove the Roboto font from everything instead we have to apply the Roboto Mono to the pipeline editor.

@go2sh What plugin do I need to install to see this issue? Could you describe the steps to reproduce it?

go2sh commented 8 years ago

@afonsof You need the pipeline plugins (pipeline-job). Then create or alter a pipeline project. In the project configuration view you find Pipeline and then Script. This textarea is problematic. image Note that I marked the end of the line. :) Thank you for fixing it. I really appreciate your work.