search

afonsof / jenkins-material-theme

Beautify your Jenkins with the Material Design theme!
http://afonsof.com/jenkins-material-theme
MIT License
1.72k stars 355 forks source link

Fix project page back btn overlapping menu optns #59

Closed trash closed 8 years ago

trash commented 8 years ago

Before

screen shot 2016-04-21 at 5 52 12 pm

After

screen shot 2016-04-21 at 5 52 36 pm
afonsof commented 8 years ago

@trash this is not the expected result. I should look like the following screenshot: image

What browser are you using?

trash commented 8 years ago

@afonsof Ah wow that looks totally different. I'm on Chrome (OSX). If the difference is that drastic I'm beginning to think it may be an issue with our personal setup.

Shadow00Caster commented 8 years ago

I do not see that issue, I'm on Windows using Chrome (also tested in FF and IE). The arrow does however cover up the logo (whether it's the Jenkins logo or a custom logo); I am not sure if that's intended or not.

I ended up removing my custom logo because it looked ugly when the back arrow was covering it up, without the custom logo just the arrow shows and the Jenkins logo is fully covered (or hidden all together).

afonsof commented 8 years ago

@Shadow00Caster when I move the back button to the top of the page my intention was turn the navigation fluid in favor of Material Design principles. But you are right! There's a bug where the back button does not totally cover the customized logo. I've created the issue https://github.com/jenkins-contrib-themes/jenkins-material-theme/issues/63 to solve that problem.

Shadow00Caster commented 8 years ago

@afonsof Awesome, thanks!