search

afonsof / jenkins-material-theme

Beautify your Jenkins with the Material Design theme!
http://afonsof.com/jenkins-material-theme
MIT License
1.72k stars 355 forks source link

Jenkins v2 pipeline code editor is broken #90

Closed svscorp closed 7 years ago

svscorp commented 8 years ago

Hi @afonsof

First of all, thank you very much for this initiative. Jenkins looks much better applying this theme! That's a great job done!

I'd like to report on one more issue (found by @jos4github), in addition to #73

When editing pipeline as code, editor behaves very badly. You can't really figure out what are you typing or what character you will delete if you place your cursor in a middle of a work and press backspace.

Example:

I placed cursor as on screenshot: theme-bug-1

I want to add one space, where do you think it applies? Look below :) theme-bug-2

Thank you.

wbagdon commented 7 years ago

Which browser, OS, version of material-theme, and version of Jenkins are you using? I resolved this issue with #62 previously and it still seems to work with Jenkins 2.31 and material-theme 1.3.2 on chrome windows

jos4github commented 7 years ago

We are Using Windows7 with Chrome (Version 54.0.2840.99 m (64-bit)) and also IE 11 on both browsers I have the same issue. Jenkins is running on a linux server.

Jenkins version is 2.32 (but with version 2.31 the issue was found) and material-theme is 1.3.2 as you can see in the screenshot. It also shows the that when you wants something to the end of the line the cursor is say 3 chars of track.

materialthemeissue

wbagdon commented 7 years ago

The fonts are loaded client side from fonts.googleapis.com Does your Win7 machine have access to the internet to download the font? Does this page render correctly in your browser? https://developers.google.com/fonts/docs/getting_started I suppose a fallback mono font should be used in case the Google font cannot be downloaded

luka5z commented 7 years ago

I'm experiencing the same exact problem with Firefox 50.1.0 and Ubuntu 16.04.

wbagdon commented 7 years ago

Can you try building this and let me know if it works for you? https://github.com/wbagdon/jenkins-material-theme/tree/linux_font_patch

I tried it with Firefox 50.1.0 and Ubuntu 16.10 and Win 7 and Firefox 50.1.0.

In case you cannot build it, here is the CSS file (just needs the extension changed back to CSS)

material.css.txt

svscorp commented 7 years ago

@wbagdon the google dev page opens correctly. But we both experiencing same behavior. Need to reapply the theme and see if it is still the case.

Thank you very much returning on this and contributing your time to help with troubleshooting :)

svscorp commented 7 years ago

@wbagdon @jos4github Just checked. Same situation - clicked on the end of a line, cursor is somewhere 3.5 symbols back...

Win 7 Jenkins 2.37 material-css generated from the site as of now Chrome: Version 55.0.2883.87 m

wbagdon commented 7 years ago

Generated from my fork and branch linux_font_patch? I've bumped the version to 1.3.3 now if you want to rebuild and check that you have the right version.

igisur commented 7 years ago

@wbagdon I've tried attached "material.css.txt" and it does work with Jenkins 2.35, Firefox 50.1.0 on Win10.

wbagdon commented 7 years ago

@svscorp @jos4github @luka5z Any luck with my attached file or building from my forked branch?

svscorp commented 7 years ago

@wbagdon @jos4github @afonsof

I checked your attached file - it is working fine. Great Job!

Can it be merged / compiled to css in the main project?

afonsof commented 7 years ago

For sure @svscorp!

@wbagdon could you create a pull request?

wbagdon commented 7 years ago

Already created -- #96

vadim-shb commented 7 years ago

Hi. Thanks for your great work! It seems like PL is accepted. Is the patch already in http://afonsof.com/jenkins-material-theme/dist/material-blue-grey.css? Or it will be updated some time later? (With this css issue is still reproducible)

afonsof commented 7 years ago

Hi @vadim-shb. The CSS file was just updated. Thank you!