feat: use default `discord_client_id`

afonsojramos / discrakt

The Trakt 🎥 Plex ▶️ Discord 🎮 Rich Presence that you didn't know you needed.

https://github.com/afonsojramos/discrakt/releases/latest

MIT License

90 stars 11 forks source link

feat: use default `discord_client_id` #73

Closed afonsojramos closed 8 months ago

afonsojramos commented 8 months ago

📑 Description

Partially closes #46. Changes related to Trakt might also be brought into this PR if changes are not too drastic.

✅ Checks

[x] code: My pull request adheres to the code style of this project
[ ] docs: Added / updated
[ ] tests: All the tests have passed

ℹ Additional Information

Please take a look if it makes sense @sitiom @rollingmoai

afonsojramos commented 8 months ago

@sitiom Interesting 🤔 But that seems to open these API keys to be used outside of their intended use....

afonsojramos commented 8 months ago

@sitiom Further investigation proved that it is indeed not prudent that I ship these API keys with the binary as that would be a break of the ToS with TMDB.

sitiom commented 8 months ago

Where is it specified? And how come the TMDB scraper addon above from Kodi not break TOS?

afonsojramos commented 8 months ago

Best I've found was this tbh: https://www.themoviedb.org/talk/6272acd4a313b812cd7aab5e

But with so many out there... Why not?