search

afonsojramos / discrakt

The Trakt 🎥 Plex ▶️ Discord 🎮 Rich Presence that you didn't know you needed.
https://github.com/afonsojramos/discrakt/releases/latest
MIT License
85 stars 10 forks source link

Unable to use my own keys anymore #82

Closed samip5 closed 5 months ago

samip5 commented 5 months ago

🔍 Is there already an issue for your problem?

📝 Description

Previously I was able to use my own keys for Discord and TMDB, and I wish to continue to do so but recent changes, seem to have disabled that. That to me is a bug.

🪜 Steps To Reproduce

  1. Pull current latest release
  2. Set Discord and TMDB API things in credentials.ini
  3. See that those are not being used.

ℹ System Info

OS: Gentoo
Project version: v2.5.0

📸 Screenshots

No response

afonsojramos commented 5 months ago

I get your motivations, but what is the reasoning behind wanting to do that? As discussed in #46, there are similar apps that have them built-in also.

samip5 commented 5 months ago

what is the reasoning behind wanting to do that

Specially with the Discord app one, I want to be able to specify myself the app name that shows up for one.

afonsojramos commented 5 months ago

You can always compile yourself and set it yourself in the code. And to be honest, I think that's the final decision on it. Obviously this is not a "full-fledged" product, but as a product I want some standardisation here, plus, if I can remove as much config as possible the better, because it means that things are more reproducible and maintainable.

afonsojramos commented 5 months ago

Currently the only thing that we have in the config is trakt. If we also fully move to oauth, then that will mean that we actually no longer even need a config file, which I see as a win.

samip5 commented 5 months ago

That's definitely your choice to make, but I thought it wouldn't be much effort to prefer an env var and use that instead if exists, but fair enough i suppose.