search

afonsolage / bevy_ecss

Bevy crate which uses a subset of CSS to update Bevy ECS components
Apache License 2.0
98 stars 11 forks source link

Upgrade cssparser to 0.33 #32

Closed afonsolage closed 9 months ago

afonsolage commented 9 months ago

Fixes #31

Most of the changes was related to cssparser::Color which has it's own crate after 0.33.

Another change is the required implementation of the new RuleBodyItemParser on PropertyParser to also implement QualifiedRuleParser.

In general, it's very painful to upgrade cssparser due to its lack of migration guide or even a decent changelog between versions. We should consider switching to https://github.com/parcel-bundler/lightningcss which not only uses cssparser but also selector (we implement our own selector logic, which isn't optimal).

afonsolage commented 9 months ago

I've also did a minor version bump, since even tho the cssparser was a big change, there shouldn't be any change on bevy_ecss API to end user.

Leinnan commented 9 months ago

It looks great!