Fix crashes when parsing malformed menus - Githubissues

afonsotrepa / PocketGopher

Gopher browser for android written in java

The Unlicense

47 stars 9 forks source link

Fix crashes when parsing malformed menus #15

Open jnlon opened 5 years ago

jnlon commented 5 years ago

Hi, this PR adds better exception handling to Connection.getMenu() resolving several crashes I have noticed in real-world gopher holes. It prevents crashes in at least the following cases:

A menu line is missing the item type character
A menu line port does not parse as an integer

In both cases the line is treated as an unknown page.