request line is terminated by \n instead of \r\n

afonsotrepa / PocketGopher

Gopher browser for android written in java

The Unlicense

47 stars 9 forks source link

Closed woffs closed 5 years ago

woffs commented 5 years ago

When sending an empty request (to gopher://taz.de/ in this case) the server just gets "\n". It should get "\r\n" according to RFC 1436.

mdom commented 5 years ago

gopher://taz.de now also accepts a newline, but i imagine a lot of servers out there won't handle a request like this.

afonsotrepa commented 5 years ago

Ah, good spot. It's so common for servers to accept both that it hasn't come up before but it's definitely worth a fix.

I'll fix it right now but it might take a while for it to drop on f-droid because I don't really remember how that stuff with them works.

afonsotrepa commented 5 years ago

Bug fixed and app version updated, F-droid should pick up on it in a few hours.