fix: typography switch, text-left alignment, AligIcon's active state, types

afordigital / perfect-line-height

https://perfect-line-height.vercel.app

22 stars 9 forks source link

Closed MarcosNASA closed 9 months ago

MarcosNASA commented 9 months ago

Fixes:

AlignIcon's active state.
Typography switch.
- Since fonts are loaded dynamically, UnoCSS was stripping the fonts from the CSS output bundle. Adding the font-* properties to the safelist prevents UnoCSS from stripping them.
Text-left-alignment.
- Similar fix to the typography one.
Added strict types to ModeViews and Typographys.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
perfect-line-height	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 25, 2024 4:08pm

MarcosNASA commented 9 months ago

Re formatting: great call, I'll revert the formatting ASAP.

Re the type imports: I don't hold a strong opinion here, happy to defer what's best to you and commit your changes. 🫡

Thanks, Kevin!

kevinzunigacuellar commented 9 months ago

Re the type imports: I don't hold a strong opinion here, happy to defer what's best to you and commit your changes. 🫡

@MarcosNASA Creo que es una issue de rollup que no distingue bien los types imports. Pornerle el type por eso como "buena practica"

Quizas ya fue solucionado y estoy hablando fuera de lugar pero se me quedo esa practica 😆