aforemny / elm-mdc

Elm port of the Material Components for the Web CSS/JS library
https://aforemny.github.io/elm-mdc
Apache License 2.0
354 stars 43 forks source link

Tab background ripple does not fade #220

Closed mkreisel closed 5 years ago

mkreisel commented 5 years ago

In the tabs component, when a tab is selected the background should ripple to a dark shade, then fade to a lighter background color for the selected tab. This behavior can be observed from the official MDC tab demo. However in the elm-mdc tabs component, the darker rippled background does not fade unless you click again outside the tab. At that point it goes to the lighter shade, when it should actually remove all background color. The gif below illustrates the problem and was recorded in Chrome Version 75.0.3770.80 (Official Build) (64-bit) on Ubuntu 18.04.

mdc_tab_highlight

aforemny commented 5 years ago

I am closing this because I am assuming this has been fixed in #219. If the issue persists, please re-open. Thank you both for the report and assistance in solving this!