Add ability to generate ECDSA certificate

afosto / yaac

Yet another ACME client: a decoupled LetsEncrypt client

Other

219 stars 85 forks source link

Add ability to generate ECDSA certificate #33

Closed 0x4r45h closed 2 years ago

0x4r45h commented 3 years ago

Let'sEncrypt supports both RSA and ECDSA certificates. this PR adds ability to generate ECDSA certificates too.
also set the default certificate type to ECDSA , so it can be treated as a breaking change

bakkerpeter commented 3 years ago

I think this could be done, but please look at https://github.com/afosto/yaac/pull/18 Upon client creation there is a way of setting options for the client. I think this should be used in order to achieve this and also keep the code clean.

simensen commented 2 years ago

Hello! I'd love to see this move forward. Is there anything I can do to help?

bakkerpeter commented 2 years ago

Thanks for your message and yes of course!

First we would need to resolve some conflicts, next I think we should follow the direction taken in

Ill happily review / merge your PR, thanks!