search

afosto / yaac

Yet another ACME client: a decoupled LetsEncrypt client
Other
219 stars 85 forks source link

Allow Flysystem 3.0 #50

Closed streamingsystems closed 2 years ago

streamingsystems commented 2 years ago

Hi,

I use your repository to interact with LetsEncrypt. I also use it within Laravel. Laravel upgraded to v9 yesterday and they moved to Flysystem 3. As such I could not upgrade because this package did not allow Flysystem 3.

It seems like it works fine with Flysystem 3 from the tests I did.

Thanks!

-Rob

streamingsystems commented 2 years ago

I also with with a major CDN that only allows 2048 keys and this was hardcoded to 4096. I made it such that I can pass in the key length as a config option to the client.

bakkerpeter commented 2 years ago

thanks for the PR, I'll look into it this week.