afosto / yaac

Yet another ACME client: a decoupled LetsEncrypt client
Other
215 stars 84 forks source link

Exception: Undefined array key "certificate" #63

Open xolf opened 1 year ago

xolf commented 1 year ago

An Undefined array key "certificate" got thrown when I want to retrieve the certificate. The HTTP selftest and authorization succeeded. Did someone else had a similar issue so far?

 $certificate = $client->getCertificate($order);

I just did some debugging and I found out that the order returns a ready status but the finalize endpoint has processing as a status.

As mentioned in https://community.letsencrypt.org/t/error-when-finalizing-order/104649 and https://datatracker.ietf.org/doc/html/rfc8555#section-7.4 the Retry-After header should be respected. Within https://github.com/afosto/yaac/blob/master/src/Client.php#L323 I did not found any logic handling the specific header. Is this on purpose or am I the first one stumbling across this kind of behaviour?

cliffordjames commented 1 year ago

I have exactly the same issue!

Edit: This is only the case on Client::MODE_STAGING.

bessone commented 7 months ago

Same problem to me using staging mode.

dbeaubien commented 7 months ago

Looking at forks of this repository, the following might have implemented a solution to this issue:

https://github.com/afosto/yaac/compare/master...OpenSourceCommerce:acme-client:master