search

afrad / angular2-websocket

Websocket wrapper for angular2 based on angular-websocket
Apache License 2.0
210 stars 84 forks source link

Need to update rxjs version to 5.4.2 #86

Open bougnat12 opened 7 years ago

bougnat12 commented 7 years ago

When upgrading my project with Angular 4.3.3, rxjs 5.4.2, Typescript 2.4.1 I have this issue related to the older rxjs version included into angular2-websocket:

ERROR in /Users/pfradin/Documents/projets/git/mad-web-ui/node_modules/angular2-websocket/node_modules/rxjs/Subject.d.ts (16,22): Class 'Subject' incorrectly extends base class 'Observable'. Types of property 'lift' are incompatible. Type '<T, R>(operator: Operator<T, R>) => Observable' is not assignable to type '(operator: Operator<T, R>) => Observable'. Type 'Observable' is not assignable to type 'Observable'. Type 'T' is not assignable to type 'R'.

I just replaced the rxjs 5.0.0-beta.12 with 5.4.2 into my node_modules/angular2-websocket/package.json file, redo an npm install locally to this directory and the issue is resolved.

I attached the package.json file and hope that helps.

Regards

Patrick package.json.zip

bougnat12 commented 7 years ago

I omit to spécify I used 0.8.1 version because 0.9.3 contains a blocking bug for me.