search

afrad / angular2-websocket

Websocket wrapper for angular2 based on angular-websocket
Apache License 2.0
210 stars 84 forks source link

FR WebSocketConfig parameters should be optional #92

Closed mburger81 closed 7 years ago

mburger81 commented 7 years ago

We think WebSocketConfig parameters should be optional and merged with default values.

So for example on using default initial and maxTimeout we can only pass reconnectIfNotNormalClose and set it true and use the default paramters. We created a PR for that #91

afrad commented 7 years ago

merged

mburger81 commented 7 years ago

Thx, please update package.json and release a new version on npm thx.

afrad commented 7 years ago

done

mburger81 commented 7 years ago

@afrad you have also to update the definition file

afrad commented 7 years ago

done

mburger81 commented 7 years ago

still same issue .... what't do you intend with done? there is no commit about it? Also I think you should do the bundle in a different way, with an automatic build script. I could do a PR for that in the next week?