search

afragen / git-updater

This WP plugin will update GitHub, Bitbucket, GitLab, and Gitea hosted plugins and themes
https://git-updater.com
MIT License
3.19k stars 462 forks source link

GHU adds Bitbucket username and commit number to plugin folder name #226

Closed gantsta closed 9 years ago

gantsta commented 9 years ago

When I install a plugin from a (private) Bitbucket repo using GHU's Install Plugin feature the resulting folder that gets added to wp-content/plugins is: bitbucketusername-bitbucketreponame-repocommitnumber

So, for my plugin called ajg-messages, the resulting folder is called:

gantsta-ajg-messages-16e3de387735

Then, once I update the plugin it renames the folder to the new commit number and, in so doing deactivates the plugin because it can't find the original version of the plugin.

Any idea why this may be. I am developing on a localhost web server (MAMP Pro).

gantsta commented 9 years ago

FYI, I just tried the same operation on a live web server with the same result so it doesn't look as if the local server environment is the cause of this issue.

I also tried setting the Bitbucket repo to public rather than private but still got the same result.

ghost commented 9 years ago

Can you share a link to your repo ?

afragen commented 9 years ago

Can you add afragen with read privileges to the repo?

gantsta commented 9 years ago

Thanks Andy. I have added your user afragen to the repo and granted read privs. The repo URL is: https://gantsta@bitbucket.org/gantsta/ajg-messages.git Appreciate your help.

afragen commented 9 years ago

@gantsta you need to change the header URI to Bitbucket Plugin URI: https://bitbucket.org/gangsta/ajg-messages

ghost commented 9 years ago

self-moderated :)

afragen commented 9 years ago

@franceimage GitHub Updater is definitely opt in. Isn't it wonderful that people have a choice for this primary functionality. I won't go into the differences in our projects, but fundamentally they both allow a user to have automatic update function for plugins and themes. I have tried to put the onus for updating on the developer, not on the user. From a user's perspective all they need to do to have a plugin or theme update is to install and activate this plugin and install any other plugin that supports it. They don't have to create a connector, a plugin/theme setting, or make choices on how they want to receive updates.

If you wish to suggest your own project to users here, I won't stop you but the OP is asking a question and I'm trying to answer it.

My advice would be to write about your project. Describe it's feature, uses, etc. Ask others to evaluate your code and provide feedback, some will some won't. I wish you great success with your plugin as I think it offers another alternative via a different method.

Cheers, Andy

gantsta commented 9 years ago

Thanks Andy. The change to the Bitbucket Plugin URI that you mentioned has resolved the issue. Really grateful for your assistance with this and for creating such a useful plugin.

afragen commented 9 years ago

You're very welcome. Be sure to make the same changes upstream in the repo too.