search

afragen / git-updater

This WP plugin will update GitHub, Bitbucket, GitLab, and Gitea hosted plugins and themes
https://git-updater.com
MIT License
3.18k stars 462 forks source link

Release with dependencies #628

Closed Lewiscowles1986 closed 6 years ago

Lewiscowles1986 commented 6 years ago

So I have a plugin with an external composer dependency.

I created a release (matching readme version), and then created "{$repo}-{$headtag}.zip" as-per https://github.com/afragen/github-updater/issues/407#issuecomment-226255967

For some reason it downloads master branch, not the release. Do I need to use a token? Do I need to release with the Release Asset: true prior to changing the format for pulling updates?

I have Release Asset: true in this release and the release is tagged with "{$repo}-{$headtag}.zip" I'm just not sure what is going wrong.

afragen commented 6 years ago

Can you share the URL? It will make it easier for me to look at the repository to answer questions.

afragen commented 6 years ago

I looked in your repos and saw WordPressSVGPlugin. I assume that’s the plugin you’re referring to.

I was able to install it. Decrease the version number locally and update using the release asset. To test I usually just decrease the version number of the installed plugin.

How did you install the plugin? If you installed via GHU’s remote install, you would need to to the above as it would install the non-functional master branch.

Lewiscowles1986 commented 6 years ago

Sure. Also checked https://github.com/afragen/github-updater/wiki/Settings#release-assets

https://github.com/Lewiscowles1986/WordPressSVGPlugin/releases/tag/1.8.2

Edit: I think it's referencing an orphaned commit (force push glitch?)

afragen commented 6 years ago

It seems to be working as expected for me, as above. If it’s not working on your end can you provide some information. What is current installed version? Have you tried refreshing the cache?

Lewiscowles1986 commented 6 years ago

:blush: Fixed. It was a release referencing an orphaned commit for 1.8.2. Thank you and sorry.

Info:

GitHub Updater: 7.4.3 WordPressSVGPlugin: 1.8.2 (1.8.3 fixes) WordPress: 4.9 Ubuntu Trusty PHP 7.1 (Dreamhost shared) Ubuntu Xenial PHP 7.1 (DigitalOcean VPS's using Docker alpine PHP)

afragen commented 6 years ago

Not a problem. Glad it’s working.