afragen / git-updater

This WP plugin will update GitHub, Bitbucket, GitLab, and Gitea hosted plugins and themes
https://git-updater.com
MIT License
3.17k stars 462 forks source link

Can't see tabs on WPEngine hosted site after upgrade #956

Closed shoreline-chrism closed 3 years ago

shoreline-chrism commented 3 years ago

Just updated to v10.x. I upgraded the site on a yet-to-be-live production environment on WPEngine and the tabs aren't showing up. I installed wp-crontrol and triggered the associated hooks wp_update_themes() and wp_update_plugins() and i could see the functions hooked up, but it does nothing. I also bypassed wp-cron for debugging through the option and saved changes, refreshed caches, ran those same hooks and the tabs to install plugins or themes aren't showing up. Everything else seems to be there.

There is no obvious error in the logs. I even uninstalled the plugin completely, re-installed the new version fresh with the same results.

The only thing I can think of is I see in the "Scripts" pane in query monitor, that a dependency, 'heartbeat' is missing. This was happening with the new version, too, but I think it's related to WPEngine's stack which might disable heartbeat on it's own for some other solution so the sites aren't hammered on their servers.

The image below is on the v9.10.0 plugin, but the same error was there on new plugin. Any thoughts anyone? I wish I had more info to give you but I'm not seeing anything in the logs. Here's some environment info:

WordPress Version 5.7.1 Environment Type (Help) production WP_DEBUG false WP_DEBUG_DISPLAY true WP_DEBUG_LOG false SCRIPT_DEBUG false WP_CACHE true CONCATENATE_SCRIPTS undefined COMPRESS_SCRIPTS undefined COMPRESS_CSS undefined WP_ENVIRONMENT_TYPE undefined

Server Software Apache Version Unknown Address 127.0.0.1 Host pod-140095:apache2_74:201 OS Linux 5.4.0-1043-gcp

afragen commented 3 years ago

Can you screenshot the Settings page? Also check the bypass WP-Cron in the Settings page.

shoreline-chrism commented 3 years ago

Here's the settings page:

A little more is popping up in the logs-- here's what happened at some point during upgrade process:

[25-May-2021 18:11:18 UTC] PHP Fatal error:  require_once(): Failed opening required '/nas/content/live/trainyard/wp-content/plugins/github-updater/vendor/freemius/wordpress-sdk/includes/sdk/FreemiusWordPress.php' (include_path='.:/usr/share/pear/php:/usr/share/php') in /nas/content/live/trainyard/wp-content/plugins/github-updater/vendor/freemius/wordpress-sdk/includes/class-fs-api.php on line 104
shoreline-chrism commented 3 years ago

I checked the bypass wp-cron and clicked save, refresh caches, ran the events again associated with this plugin and nothing still.

shoreline-chrism commented 3 years ago

Just to reiterate the steps I took-- I was installing Github Updater (v9.10.0) on a site, and that's when I noticed the plugin had an update-- tried to upgrade through wp-admin plugins screen. It initially failed (prob due to renamed plugin file/branding change) and then clicked activate twice before it worked.

When i revert to the old version of the program, everything seems to work ok without bypassing wp-cron or anything.

afragen commented 3 years ago

The update from GitHub Updater 9.x to Git Updater 10.x renames the plugin files. Consequently the plugin automatically deactivates and will need to be reactivated, probably twice, to complete the renaming.

https://git-updater.com/knowledge-base/updating-from-github-updater-to-git-updater/

The fact that I still see the wp-content/plugins/github-updater/... in the error means that the plugin hasn't completed it's renaming.

Reverting back and forth between these versions is likely to be an issue.

Is there an issue with the Git Updater 10.x installed and active? It should be wp-content/plugins/git-updater/git-updater.php

afragen commented 3 years ago

When i revert to the old version of the program, everything seems to work ok without bypassing wp-cron or anything.

Let's stick to figuring out if there's an issue with the latest version. Should be 10.0.2

afragen commented 3 years ago

BTW, what missing tabs are you referring to?

https://git-updater.com

shoreline-chrism commented 3 years ago

The "Theme" and "Plugin" tabs where I used to install my plugins from GitHub.com

On Tue, May 25, 2021, 4:22 PM Andy Fragen @.***> wrote:

BTW, what missing tabs are you referring to?

https://git-updater.com

β€” You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/afragen/git-updater/issues/956#issuecomment-848233586, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACFS7ZWCTYPXO7ZTUEWATJDTPQBHPANCNFSM45P46KKA .

afragen commented 3 years ago

The update and rebrand split the plugin into core and premium features.

Plugin and theme installation is now in the premium feature set. Please take a look at https://git-updater.com for loads more information.

shoreline-chrism commented 3 years ago

That's unfortunate. I work for a small business and your tool has been great, but I guess I'll just stick to WP-CLI for now. Thanks for your previous work on the plugin before the split.

Since I'm one of the only developers who could touch the repos of our plugins it was nice to be able to delegate some installation and upgrade tasks to some content and SEO team members.

On Tue, May 25, 2021, 8:15 PM Andy Fragen @.***> wrote:

The update and rebrand split the plugin into core and premium features.

Plugin and theme installation is now in the premium feature set. Please take a look at https://git-updater.com for loads more information.

β€” You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/afragen/git-updater/issues/956#issuecomment-848363342, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACFS7ZQGSDUZZIX6PS76A7DTPQ4QJANCNFSM45P46KKA .

shoreline-chrism commented 3 years ago

I struggle to get buy-in from some team members for git at all and this was a nice real-world tie-in. Really bummed. I'll try to see if my boss wants to spend $300/ month

On Tue, May 25, 2021, 9:00 PM Chris Matthias @.***> wrote:

That's unfortunate. I work for a small business and your tool has been great, but I guess I'll just stick to WP-CLI for now. Thanks for your previous work on the plugin before the split.

Since I'm one of the only developers who could touch the repos of our plugins it was nice to be able to delegate some installation and upgrade tasks to some content and SEO team members.

On Tue, May 25, 2021, 8:15 PM Andy Fragen @.***> wrote:

The update and rebrand split the plugin into core and premium features.

Plugin and theme installation is now in the premium feature set. Please take a look at https://git-updater.com for loads more information.

β€” You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/afragen/git-updater/issues/956#issuecomment-848363342, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACFS7ZQGSDUZZIX6PS76A7DTPQ4QJANCNFSM45P46KKA .

afragen commented 3 years ago

Unlimited license is $300/year not month. πŸ˜‰ Depending on how many sites you use it on there are less expensive options.

shoreline-chrism commented 3 years ago

I feel like installing and updating plugins is CORE functionality. I can no longer install plugins from a github.com repo. It feels like you've completely ripped any usefulness from this plugin. And made worse, I now have dozens of inactive updated versions of this plugin on websites that I need to remove and I have to spend days now to rework my entire regimen. I have to bring a site local, git checkout my plugins and rsync them up.

Really, truly, disheartening.

afragen commented 3 years ago

@shoreline-chrism I very sorry you feel this way. I have been developing this plugin for about 8 years now and in that time I have provided all features for free. I have a donation link in the plugin but it is seldom used. I made a decision to begin monetizing this plugin to justify the time spent in its upkeep, support, and development. I'd like to believe I have provided exemplary support.

It is clearly a developer tool in its premium form. There are always ways to duplicate the function of the premium features, some of these will cost money and all will cost time.

What is your time worth?

What do you think having these premium features is worth, per site, per month?

I have provided many license options and I don't feel they are unreasonable.

shoreline-chrism commented 3 years ago

I understand your position and agree that you should have made a pro version of the plugin. My only argument is that installing and updating the plugin through the wordpress admin area is the core feature of this product. As a small development team (3 developers, 3-4 content/seo persons) that works on primarily local small business websites, I'm not sure if my boss will justify the cost. I think the price is fine for a larger team, it just won't work for ours.

I'm sorry for giving you grief, but there's been a lot of talk lately about these plugins just up-and-changing and leaving developers in the lurch (like WP User Avatar) and I've been a little sensitive to the matter.

I'll just upload plugins via a ZIP file from github and use the plugin to update them for now. I wish you luck-- it is clearly an essential tool if I'm crying about it so much.

afragen commented 3 years ago

Chris, I hope your boss understands the value Git Updater PRO brings to you and your team. $300 for an unlimited yearly license doesn't seem like a lot, especially given the time it will save you.

You are saving what sounds like several hours of work and allowing some of that work to be done by others. I don't license it this way, but that's less than $1.00/day.

pattyok commented 3 years ago

I was completely confused by the update and the language around the split of pro vs free. It appears that the free plugin is not useful at all? Just took me several hours to come to that conclusion. I understand the need to monetize your work, but the documentation around this change doesn't instill a lot of confidence...

afragen commented 3 years ago

@pattyok The free plugin allows dashboard updates for any plugin or theme that contains the appropriate header and resides in GitHub, Bitbucket, GitLab, Gitea, or any of their self hosted versions. I hardly think this is worthless.

Which documentation are you referring to? There's a whole website with information. https://git-updater.com

I'm curious why you think the core plugin is not useful?

pattyok commented 3 years ago

It seems to have stopped working in my case. It recognizes that there is an update but it wont actually make the update... without the tabs that were there previously its hard to troubleshoot. I do not use a master branch, so I don't know if that is my issue or not...?

afragen commented 3 years ago

Can you screenshot some of those things?

Are there any error notices?

If you don't use a master branch you must designate the branch in a Primary Branch header.

shoreline-chrism commented 3 years ago

Didn't mean to close issue-- meant to say that I agree with the commenter. My immediate reaction was confusion because I didn't understand core functionality would be lost when i looked at the docs. It could be a little clearer.

afragen commented 3 years ago

The core functionality is just that, core, it doesn't require the PRO plugin.

If you're having issues with an update, please join the Slack and ping me.

pattyok commented 3 years ago

It recognizes there is an update: image

It goes through making the update: image

Then on refresh it still indicates it needs an update: image

No errors are indicated within the admin interface or the logs.

This is my header: image

afragen commented 3 years ago

@pattyok are you tagging your releases? If yes, are you tagging for each version?

if you do the update from the core update page you will be able to see what the download URL looks like. Refer to Tagging, https://git-updater.com/knowledge-base/versions-branches/

pattyok commented 3 years ago

Yes, tagging releases, they match the version number. Also note that after the attempted update it reverts back to the last version that was updated prior to the update of the plugin (the last time that it worked). Which made me think that it would only work with the pro version.

Not sure what you mean by the core update page and viewing the download url.

afragen commented 3 years ago
screenshot_62

Can you screenshot that for your update?

afragen commented 3 years ago

@pattyok the situation you're describing can easily happen if you forget to tag a release. When tags are present they are polled from the API and sorted using array_sort. The highest value (tag) is returned. If you've changed your style of tagging, ie, v1.2.9 from 1.2.8 they will not sort how you think.

afragen commented 3 years ago

If you want to give me temporary access to your repo I might be able to figure it out quicker.

pattyok commented 3 years ago

Thanks for your help in figuring this out! I had indeed tagged a release incorrectly.

Sorry for the unfortunate coincidence that I ran into the problem at the same time of the plugin update.

In case anyone else encounters the same issue. I had missed a dot in one of my tags. Deleting that release solved my problem.

On Thu, Jun 3, 2021 at 5:12 PM Andy Fragen @.***> wrote:

If you want to give me temporary access to your repo I might be able to figure it out quicker.

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/afragen/git-updater/issues/956#issuecomment-854264439, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASODOHUXRJJJZQD2RVLNNLTRAK65ANCNFSM45P46KKA .

afragen commented 3 years ago

I'm closing this issue. If there are any other concerns please create a new issue.

afragen commented 1 year ago

FYI, I’m in the process of releasing a new model. Everything is back in the core plugin and there is no more need for the PRO plugin. I am monetizing the ability to use authenticated API requests. It’s only $20/yr unlimited number of sites.

You can find a current pre-release at https://git-updater.com