vcs detection

[Raruto]

In response to: https://github.com/afragen/local-development/issues/4, WP_Automatic_Updater::is_vcs_checkout is a tree walker function.

.. it breaks all if a parent folder is under vcs ..

---

In particular, in this version of mine:

• automatically added checkboxes are disabled by default
• a visual feedback is added to the admin bar when working on localhost
• increased visibility of the "in local development" label

[afragen]

Can we split these into separate PRs. I have to see what the styling changes look like. Also, it's better to add the CSS using wp_enqueue_style(). Put the CSS in assets/css.

[Raruto]

Can we split these into separate PRs.

Ok, done.

Also, it's better to add the CSS using wp_enqueue_style(). Put the CSS in assets/css.

This is generally true but it's not error-proof.

Sometimes, especially during development, it can happen that assets files are not correctly loaded by browser (with the inline strategy this simply cannot happen).

I have to see what the styling changes look like.

The aesthetic modification is really small (3 css rules), but I consider it very effective (to easily distinguish local instances). Anyway, I had also added a checkbox in extras to disable it in case you don't want it ...

#wpadminbar #wp-admin-bar-site-name > .ab-item::after {
  content: " - localhost";
  font-weight: 800;
  font-family: Monospace;
  color: #fff;
}

#wpadminbar #wp-admin-bar-site-name > .ab-item {
  background-color: #008000;
  color: #ff0;
}

#wpadminbar #wp-admin-bar-site-name > .ab-item::before {
  background: url(data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIGFyaWEtaGlkZGVuPSJ0cnVlIiB3aWR0aD0iMTQiIGhlaWdodD0iMTYiIHN0eWxlPSItbXMtdHJhbnNmb3JtOnJvdGF0ZSgzNjBkZWcpOy13ZWJraXQtdHJhbnNmb3JtOnJvdGF0ZSgzNjBkZWcpO3RyYW5zZm9ybTpyb3RhdGUoMzYwZGVnKSI+PHBhdGggZmlsbC1ydWxlPSJldmVub2RkIiBkPSJNOS41IDNMOCA0LjUgMTEuNSA4IDggMTEuNSA5LjUgMTMgMTQgOCA5LjUgM3ptLTUgMEwwIDhsNC41IDVMNiAxMS41IDIuNSA4IDYgNC41IDQuNSAzeiIgZmlsbD0iI2ZmMCIvPjwvc3ZnPg==) center center no-repeat !important;
  content: " " !important;
  display: block;
  width: 16px;
  height: 21px;
}

[afragen]

Can you please make separate PRs for the CSS rules and for the icons. Both should be selectable options. If you can find/create a Gitea icon that would be great. I think differentiating public and private repos isn't necessary.

[afragen]

I just realized I have inline css in here too. Go ahead and make the PR that way.