aframevr-userland / aframe-cli

💻 A command-line tool for building :a: A-Frame WebVR scenes.
MIT License
21 stars 12 forks source link

aframe new my-model --template model-viewer #22

Open caseyyee opened 7 years ago

caseyyee commented 7 years ago

It seems that any template alias with "-" in the name doesn't work.

Just using --template model works though. Not sure why?

node index.js new my-3dmodel --template model-viewer
11:00:01 - log: Using template "aframevr-userland/aframe-model-viewer-template …
11:00:01 - log: Cloning git repo "git://github.com/aframevr-userland/aframe-model-viewer-template.git" to "/Users/casey/.brunch/skeletons/6ceaa9508869139f31c6a71eec0a73848ad6c483"...
/Users/casey/Developer/aframe-cli/index.js:3
  throw err;
  ^

Error: Git clone error: Error: Command failed: git clone git://github.com/aframevr-userland/aframe-model-viewer-template.git "/Users/casey/.brunch/skeletons/6ceaa9508869139f31c6a71eec0a73848ad6c483"
Cloning into '/Users/casey/.brunch/skeletons/6ceaa9508869139f31c6a71eec0a73848ad6c483'...
fatal: remote error:
  Repository not found.

    at exec.then.error (/Users/casey/Developer/aframe-cli/node_modules/init-skeleton/lib/index.js:67:13)
cvan commented 7 years ago

It seems that any template alias with "-" in the name doesn't work.

I could be wrong, but I don't think that's the problem here.

the directory name is aframe-model-template. and it's because its alias is not model-viewer; it's model.

or are you referring to something else? obviously, I should make the error messages more helpful (like git does); for that, see issue #2. sorry for the confusion!

caseyyee commented 7 years ago

But when I did try to change the alias in template/index.json to model-viewer, that's the error I got. Using new my-model --template model seemed to work though. Currently in the repo it's set to just model which is fine.

cvan commented 7 years ago

image

https://github.com/aframevr-userland/aframe-cli/compare/hyphen-test

I just created a new template one with a hyphen - in it, and it worked fine. can you show me a branch?

caseyyee commented 7 years ago

I'll try again. could be some configuration error on my part.