aframevr / aframe-registry

[DISCONTINUED] Curated collection of community A-Frame components.
https://aframe.io/registry/
MIT License
77 stars 39 forks source link

Register aframe-alongpath-component #30

Closed protyze closed 8 years ago

protyze commented 8 years ago

Added the aframe-alongpath-component to the A-Frame Registry by editing registry.yml

ngokevin commented 8 years ago

Thanks! Currently looking at Inspector-ready components, ideally there'd be a way to edit the points visually (i.e., add child entities and be able to drag those around to define the points).

protyze commented 8 years ago

Huh, that totally makes sense. Missed that one. I will extend the component as suggested. Thanks!

protyze commented 8 years ago

Hi, I've updated the component with A-Frame Inspector support. See https://protyze.github.io/aframe-alongpath-component/alongpath/index.html

(Open the Inspector, select the red path-boxes and then drag the curve into position).

ngokevin commented 8 years ago

Looks great! Is there a way to clean up the scene graph a bit? Like put all those boxes under an entity, and give the wrapping entity a class name (we will show the class name in the Inspector soon).

screen shot 2016-10-21 at 3 38 11 pm
ngokevin commented 8 years ago

If we just make inspect: false and just add a bit to the README about that, then good to go! The scene graph clean up not a deal breaker.

protyze commented 8 years ago

Thank you for your feedback. I appreciate! All the inspector-entities are now cleaned up as child-elements of the ".alongpath-debug-root"-entity. Also I made some minor tweaks and updated the the inspector-Property to be false by default and described the inspector-usage in more detail in the readme. let me know if that's ok now, or if it needs some more work.

ngokevin commented 8 years ago

Awesome!

ngokevin commented 8 years ago

Could also be able to dynamically update the closed property, and perhaps use spheres instead of boxes.

fernandojsg commented 8 years ago

Supercool, first community component! thank you @protyze :)

protyze commented 8 years ago

Cool! Thanks! I will also consider the other inputs. :)