add stats-in-vr component

aframevr / aframe-registry

[DISCONTINUED] Curated collection of community A-Frame components.

https://aframe.io/registry/

MIT License

77 stars 39 forks source link

add stats-in-vr component #43

Closed machenmusik closed 7 years ago

machenmusik commented 7 years ago

https://www.npmjs.com/package/aframe-stats-in-vr-component

ngokevin commented 7 years ago

Registry:

Can you add a screenshot to the README for display?

Code Review:

In init, would look cleaner to move the giant timeout to a separate method and then bind.
In tick, can you can use the time argument instead of Date.now()?
Do you need to tick/update the stats? Doesn't the stats component handle it?

machenmusik commented 7 years ago

per discussion on aframevr/aframe#2217 I don't currently trust time values from tick.

will see what I can do for screenshot

machenmusik commented 7 years ago

(is there an example of how the screenshot should be added into the README?)

ngokevin commented 7 years ago

Yeah, a lot of the components currently in the Registry just have an image in the README.md. You can upload the image however (e.g., I drag and drop it to a dummy GitHub issue to have GitHub host it). The scripts will grab the first image.

## my-component

foo bar

![myscreenshot](https://cloud.githubusercontent/foofoobar.png)

machenmusik commented 7 years ago

ok done

ngokevin commented 7 years ago

cool. if you want, you can give it a fuzzy version so you can update asynchronously. 0.1.x. if not, i can merge

machenmusik commented 7 years ago

thx for the suggestion

ngokevin commented 7 years ago

Cool. Currently working on a GitHub bot to automate the Registry builds.