search

aframevr / aframe-registry

[DISCONTINUED] Curated collection of community A-Frame components.
https://aframe.io/registry/
MIT License
77 stars 39 forks source link

Add aframe-extras primitives: ocean, grid, tube #58

Closed donmccurdy closed 7 years ago

donmccurdy commented 7 years ago

(I assume that the 'names' field should have both ocean and a-ocean here?)

ngokevin commented 7 years ago

Sweet, just component names。

ngokevin commented 7 years ago

Would it be hard to add images + basic API docs to the READMEs published to npm?

donmccurdy commented 7 years ago

Sounds good, i'll fix the component names later today.

I'm not sure about doing READMEs. How does the README surface? Like for the physics components, which do have a README, the "?" icon is a broken link here: https://aframe.io/docs/0.5.0/components/dynamic-body.html

ngokevin commented 7 years ago

Oops, maybe not needed, I think I will update the Registry to be able to specify an image so we don't have to publish to npm.

donmccurdy commented 7 years ago

Fixed the names. Functionally this is blocked by https://github.com/aframevr/aframe-inspector/pull/463.

ngokevin commented 7 years ago

OK, I'll merge and I can now add images from Registry rather than need to have them on npm README.

ngokevin commented 7 years ago

Thanks!