aframevr / aframe-registry

[DISCONTINUED] Curated collection of community A-Frame components.
https://aframe.io/registry/
MIT License
77 stars 39 forks source link

Fair number of community registry packages aren't working right now. #59

Open donmccurdy opened 7 years ago

donmccurdy commented 7 years ago

I just tested a couple from the A-Frame homepage:

(items crossed out are now fixed)

That leap-hands is broken is my own fault; I ignored the dist folder in .npmignore. The others seem to have various issues, some missing on NPM, some throwing JavaScript errors.

Not sure how feasible it would be to test entries in an automated way.

ngokevin commented 7 years ago

Thanks. Hmm, how did you test them, via Inspector?

Not sure curation can be automated, but it's a lot of work.

ngokevin commented 7 years ago

Hmm maybe in the future, a way of reporting broken components on the Registry

donmccurdy commented 7 years ago

Yeah, I just opened the inspector and tried to add those components. I think we could automate a test ensuring that the dist file exists (which was the problem for at least two of these), but the JS errors seem harder to catch.

ngokevin commented 7 years ago

OK, ensuring the dist sounds easy at least. I'm not sure if through the Inspector is a common way to consume components anymore, so some of them might not be set up to work on Inspector.

donmccurdy commented 7 years ago

What do you mean by 'set up to work on inspector'? I guess some of mine do export something like:

AFRAME.registerComponent('foo', {...});

.... which assumes that AFRAME is in the global scope, and would break for webpacked sites.

ngokevin commented 7 years ago

For example firebase components aren't really Inspector friendly, not tested there. I do have the inspector: false option, but that's not listened to by Inspector yet.

donmccurdy commented 7 years ago

Oh I see, makes sense.

fernandojsg commented 7 years ago

It seems alongpath doesn't work either https://github.com/aframevr/aframe-inspector/issues/464