aframevr / aframe-site

:a: Official A-Frame site.
https://aframe.io/
MIT License
99 stars 143 forks source link

Add Mozilla logo to sidebar on Docs/secondary pages #420

Closed cvan closed 7 years ago

cvan commented 7 years ago

@dmarcos replaced the old MozVR wordmark with the new Mozilla wordmark (Supported by Mozilla) to the homepage in PR #418. We ought to add the same logo to the sidebar on the other pages (e.g., Docs, Blog, FAQ, etc.).

marti1125 commented 7 years ago

@cvan I would like to contribute :smile:

cvan commented 7 years ago

@marti1125 great! I'd look at

  1. set up a local copy of this project: https://github.com/aframevr/aframe-site/blob/master/README.md#local-development
  2. refer to this similar Pull Request as inspiration: https://github.com/aframevr/aframe-site/pull/418/files

let me know if you encounter any issues. thanks for helping!

marti1125 commented 7 years ago

hi @cvan I ran the project =D so Where I have to add the new logo? Could you specify me please? https://aframe.io/docs/0.5.0/introduction/

cvan commented 7 years ago

@marti1125

Here are some specific instructions:

  1. Copy the HTML for the Supported by Mozilla section from index.ejs to sidebar_header.ejs. (Ideally, if you can, instead of just copying it twice, move the HTML into a single, separate .ejs file which can be included in both places as an EJS partial like this one.)
  2. Move the styles (for .sponsor, .mozilla-logo, etc.) from index.styl to _common.styl (which both index.styl and secondary.styl require)
  3. If you need specific styles for the Mozilla logo on the homepage vs. the Mozilla logo styles for the Docs/secondary pages, then you can put those CSS style overrides here in the secondary.styl file.

Let me know where you are next and if you need additional help. Thanks for helping!

marti1125 commented 7 years ago

I added background-color: #ef2d5e; to .sponsor but it needs more with and height at top or at bottom =?

captura de pantalla 2017-04-05 a las 07 50 54 captura de pantalla 2017-04-05 a las 07 51 01
cvan commented 7 years ago

@marti1125 can you show your code on a branch of your fork of the site?

cvan commented 7 years ago

this has been done by @marti1125 in PR #424 (thanks!) - and @ngokevin nicely moved the logo on the secondary pages from the sidebar to the footer of the main content area (thanks!)