Closed donmccurdy closed 6 years ago
before (desktop) |
---|
after (desktop) |
before (mobile) | after (mobile) |
---|---|
I played with the styles a bit locally, and I'm pretty happy with how it turned out. (perhaps the color
is a bit light, but let me know what you think.)
thanks for addressing this, btw. I noticed it several times, so thank you for opening this PR.
Great! Applied your patch.
My only style comment is that -webkit-font-smoothing: antialiased;
would be nice across the board, but will leave that for another day.
EDIT: ^on second thought antialiasing makes the <pre/>
tags pretty light, so, meh.
We had no postinstall script because we don't want it running on every dependency bump. The bot will run npm install just to update dependencies and run bumpdocs separately. installdocs was just for initial.
Gotcha. The bot could run npm install --ignore-scripts
which would skip the postinstall
script from getting run.
Or postinstall
could check for the existence of the src/docs
directory, and do something like this:
"postinstall": "if [ -d 'src/_docs/' ]; then npm run bumpdocs; fi",
^I'd prefer either of @cvan's suggestions if that's acceptable. Does it hurt anything if installdocs runs redundantly? Easier to contribute if we follows the standard install + run flow.
Can you double-check aframe-site runs OK with a clean --ignore-scripts
install? It'll also disable all dependency post-installs. A bit more risky than I'd like to mess with the bot to modify a copy/paste README command for a less-trafficked repo, but we can try.
I don't have a way to test that, and am only mildly inconvenienced by the unusual build step, so it's reverted. This PR contains only style changes now.
Updated.
Increases
<code/>
font size, fixes #465.Couple other misc changes:
Add postinstall sonpm run installdocs
isn't necessary up front.Remove duplicate author line.