aframevr / aframe-site

:a: Official A-Frame site.
https://aframe.io/
MIT License
99 stars 141 forks source link

Increase <code/> font size, add postinstall script. #466

Closed donmccurdy closed 6 years ago

donmccurdy commented 6 years ago

Increases <code/> font size, fixes #465.

Couple other misc changes:

donmccurdy commented 6 years ago
before (desktop)
before-desktop
after (desktop)
after-desktop
before (mobile) after (mobile)
before-mobile after-mobile
cvan commented 6 years ago

I played with the styles a bit locally, and I'm pretty happy with how it turned out. (perhaps the color is a bit light, but let me know what you think.)

cvan commented 6 years ago

thanks for addressing this, btw. I noticed it several times, so thank you for opening this PR.

donmccurdy commented 6 years ago

Great! Applied your patch.

My only style comment is that -webkit-font-smoothing: antialiased; would be nice across the board, but will leave that for another day.

EDIT: ^on second thought antialiasing makes the <pre/> tags pretty light, so, meh.

ngokevin commented 6 years ago

We had no postinstall script because we don't want it running on every dependency bump. The bot will run npm install just to update dependencies and run bumpdocs separately. installdocs was just for initial.

cvan commented 6 years ago

Gotcha. The bot could run npm install --ignore-scripts which would skip the postinstall script from getting run.

Or postinstall could check for the existence of the src/docs directory, and do something like this:

"postinstall": "if [ -d 'src/_docs/' ]; then npm run bumpdocs; fi",
donmccurdy commented 6 years ago

^I'd prefer either of @cvan's suggestions if that's acceptable. Does it hurt anything if installdocs runs redundantly? Easier to contribute if we follows the standard install + run flow.

ngokevin commented 6 years ago

Can you double-check aframe-site runs OK with a clean --ignore-scripts install? It'll also disable all dependency post-installs. A bit more risky than I'd like to mess with the bot to modify a copy/paste README command for a less-trafficked repo, but we can try.

donmccurdy commented 6 years ago

I don't have a way to test that, and am only mildly inconvenienced by the unusual build step, so it's reverted. This PR contains only style changes now.

donmccurdy commented 6 years ago

Updated.