search

aframevr / aframe

:a: Web framework for building virtual reality experiences.
https://aframe.io/
MIT License
16.66k stars 3.97k forks source link

Allow A-Frame to enter fullscreen mono mode if headset not detected #1060

Closed ngokevin closed 8 years ago

ngokevin commented 8 years ago

Currently can't enter fullscreen because that's reserved for VR.

We should allow fullscreen (and swap out the Goggles icon for a fullscreen icon) for mono experiences if a headset is not detected.

If a headset is detected, then fullscreen will also enter VR mode.

ngokevin commented 8 years ago

This is related to https://github.com/aframevr/aframe/pull/1056 because there is less reason to have pointer lock until we support fullscreen + mono.

vr + pointerlock doesn't seem to go well together (unless we maybe restrict the pointerlock to a single axis)

cvan commented 8 years ago

I like this. And I also like the idea of making the "enter VR" button a friendlier color (like green) when a headset is plugged in.

ngokevin commented 8 years ago

Maybe Goggles when headset plugged in or mobile...else fullscreen arrows?

ngokevin commented 8 years ago

The minimum work required for this when a VR headset is not detected, then clicking on the Goggles button triggers a simple requestFullScreen.

Then we can subsequently layer on proper UI for it.

cvan commented 8 years ago

perhaps, this is one way. but we shouldn't conflate "entering VR" with "entering fullscreen" (or even being a sufficient fallback). some folks may actually be using A-Frame and just want to enter fullscreen w/o VR. or may want to enter VR but on a VR-capable device (e.g., my phone). also, what would the icon look like? a VR googles/fullscreen icon - would it be conditional?

load https://mozvr.com/demos/SECVRITY/ in Chrome and Firefox Nightly to see how we handled this for the Unity WebVR template. since game devs often want to enter fullscreen, we just gracefully add VR icons if they have VR support (even if no devices are connected yet).

/cc @caseyyee

ngokevin commented 8 years ago

Just breaking up the chunks of work.

Right now, simply just allow fullscreen.

Then work on conditional icons:

FrederickDesimpel commented 8 years ago

Why not use the same conventions like Borismus webvr-boilerplate ? Like the icons more too.

I'd like mobile non-vr fullscreen as well

having something that can be styled within the html page would be nice too.

ngokevin commented 8 years ago

Fixed by https://github.com/aframevr/aframe/pull/1474

CalumGreen commented 6 years ago

@ngokevin - was there ever an option made for fullscreen on mobile without forcing headset?

riebling commented 5 years ago

Oh man, it would be awesome to figure a way to do fullscreen split stereo to support devices that can 'do the right thing' with it. I ended up here googling for a way to do this, and hope to find one, then can remove this tangential comment :)