Custom-specified SDF fonts get inverted

aframevr / aframe

:a: Web framework for building virtual reality experiences.

https://aframe.io/

MIT License

16.68k stars 3.98k forks source link

Custom-specified SDF fonts get inverted #2339

Closed jonikorpi closed 7 years ago

jonikorpi commented 7 years ago

Every SDF font specified with a URL gets inverted. http://codepen.io/jonikorpi/pen/JELjgM

font="sourcecodepro" works normally font="https://cdn.aframe.io/fonts/SourceCodePro.fnt" gets inverted

A-Frame Version: master @ 2ac766a95454467566cc001d700857daa4bfcb11
Platform / Device: Chrome/macOS
Reproducible Code Snippet or URL: http://codepen.io/jonikorpi/pen/JELjgM

jonikorpi commented 7 years ago

Looks like setting shader="sdf" fixes it. (via mchen in Slack) Updated the example: http://codepen.io/jonikorpi/pen/JELjgM

machenmusik commented 7 years ago

this is due to late breaking changes in msdf support changing default shader to msdf, @ngokevin we should consider changing default shader back to sdf with msdf stock font / url convention detection and override