Wrong placement of scene in embedded mode on mobile

aframevr / aframe

:a: Web framework for building virtual reality experiences.

https://aframe.io/

MIT License

16.58k stars 3.93k forks source link

Wrong placement of scene in embedded mode on mobile #2373

Open lennerd opened 7 years ago

lennerd commented 7 years ago

How to reproduce: Visit the example page on a mobile device (I used an iPhone). Turn on the VR mode and tilt the phone to landscape mode. The VR mode is started, but instead of having a fullscreen filled with the canvas, the scene stucks at the position it was embedded at.

A-Frame Version: 0.5.0
Platform / Device: iPhone 7, Safari
Reproducible Code Snippet or URL: http://lennerd.taurus.uberspace.de/temp/webvr/mobile-embedded-bug.html

Screenshot:

lennerd commented 7 years ago

Played around a little bit more. This problem can be easily fixed with a position set to fixed. Not sure where to add this changes without adding BC breaks. If you maybe have more insights for me, I can try to make a PR to fix this.

https://github.com/aframevr/aframe/blob/master/src/style/aframe.css#L49

Maybe we can add and remove the fullscreen class when the VR mode is entered ore exited when in embed mode?

lennerd commented 7 years ago

Any news on this?