demos broken in 0.6.1

[joshmarinacci]

Description:

• A-Frame Version: latest from HEAD
• Platform / Device: MacOSX El Cap, Chrome & Safari
• Reproducible Code Snippet or URL:

http://localhost:9000/examples/boilerplate/hello-world/

Do a clean checkout from HEAD, npm install, then npm run dev. The server will come up. Go to the hello-world demo. There is no graphics on screen. Look at the console. There are errors about Tween.js. Is the version of tween incorrect?

A-Frame Version: 0.6.1 (Date 19-07-2017, Commit #83eb39b)
index.js:87 three Version: ^0.84.0
index.js:88 WebVR Polyfill Version: ^0.9.36
Tween.js:41 Uncaught TypeError: tween.getId is not a function
    at HTMLBodyElement.add (Tween.js:41)
    at HTMLElement.value (a-entity.js:278)
    at HTMLElement.value (a-entity.js:77)
    at HTMLElement.wrappedMethod (a-register-element.js:150)
    at HTMLElement.wrappedMethod (a-register-element.js:149)
add @ Tween.js:41
value @ a-entity.js:278
value @ a-entity.js:77
wrappedMethod @ a-register-element.js:150
wrappedMethod @ a-register-element.js:149
Tween.js:41 Uncaught TypeError: tween.getId is not a function
    at HTMLElement.add (Tween.js:41)
    at HTMLElement.value (a-entity.js:278)
    at HTMLElement.value (a-entity.js:77)
    at HTMLElement.wrappedMethod (a-register-element.js:150)
    at HTMLElement.wrappedMethod (a-register-element.js:150)
add @ Tween.js:41
value @ a-entity.js:278
value @ a-entity.js:77
wrappedMethod @ a-register-element.js:150
wrappedMethod @ a-register-element.js:150
Tween.js:41 Uncaught TypeError: tween.getId is not a function
    at HTMLElement.add (Tween.js:41)
    at HTMLElement.value (a-entity.js:278)
    at HTMLElement.value (a-entity.js:77)
    at HTMLElement.wrappedMethod (a-register-element.js:150)
    at HTMLElement.wrappedMethod (a-register-element.js:150)
add @ Tween.js:41
value @ a-entity.js:278
value @ a-entity.js:77
wrappedMethod @ a-register-element.js:150
wrappedMethod @ a-register-element.js:150
Tween.js:41 Uncaught TypeError: tween.getId is not a function
    at HTMLElement.add (Tween.js:41)
    at HTMLElement.value (a-entity.js:278)
    at HTMLElement.value (a-entity.js:77)
    at HTMLElement.wrappedMethod (a-register-element.js:150)
    at HTMLElement.wrappedMethod (a-register-element.js:150)
add @ Tween.js:41
value @ a-entity.js:278
value @ a-entity.js:77
wrappedMethod @ a-register-element.js:150
wrappedMethod @ a-register-element.js:150
Tween.js:41 Uncaught TypeError: tween.getId is not a function
    at HTMLElement.add (Tween.js:41)
    at HTMLElement.value (a-entity.js:278)
    at HTMLElement.value (a-entity.js:77)
    at HTMLElement.wrappedMethod (a-register-element.js:150)
    at HTMLElement.wrappedMethod (a-register-element.js:150)
add @ Tween.js:41
value @ a-entity.js:278
value @ a-entity.js:77
wrappedMethod @ a-register-element.js:150
wrappedMethod @ a-register-element.js:150
Tween.js:41 Uncaught TypeError: tween.getId is not a function
    at HTMLElement.add (Tween.js:41)
    at HTMLElement.value (a-entity.js:278)
    at HTMLElement.value (a-entity.js:77)
    at HTMLElement.wrappedMethod (a-register-element.js:150)
    at HTMLElement.wrappedMethod (a-register-element.js:150)

[ngokevin]

@donmccurdy we should revert the tween.js bump. Fortunately, @dmarcos did not bump his deps before he built the release so this only happens locally

[donmccurdy]

does the CI not do npm install? The older version of tween.js is deprecated; if the API change is trivial maybe we should just fix it.

[ngokevin]

It's deprecated, but it doesn't really hurt to keep the version we had previously and not add extra work / unexpectedness.

We have to manually build dists during release so the CI builds didn't make in

[joshmarinacci]

Is this something that would have been caught by unit tests? Does the CI system run the actual webGL code?

[donmccurdy]

Everything is (still) working for me locally. 😕 Tests pass, npm start works, demos work, all on a clean installation of aframe. I'm currently at @tweenjs/tween.js@16.10.0. npm 4.6.1, node v6.9.5. Is it possible there was a bad patch release of tweenjs somewhere around the time we published? Or perhaps related to https://github.com/tweenjs/tween.js/issues/358?

[joshmarinacci]

I did a fresh checkout this morning and everything is fine. It must have been a transitory issue with TweenJS.

Sent from planet Earth

On Jul 22, 2017, at 11:52 AM, Don McCurdy notifications@github.com wrote:

Everything is (still) working for me locally. 😕 Tests pass, npm start works, demos work, all on a clean installation of aframe. I'm currently at @tweenjs/tween.js@16.10.0. npm 4.6.1, node v6.9.5. Is it possible there was a bad patch release of tweenjs somewhere around the time we published? Or perhaps related to tweenjs/tween.js#358?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[dmarcos]

Good to hear! Thanks for checking again! I'll go ahead an close the issue and will reopen if necessary.