Closed joshmarinacci closed 7 years ago
@donmccurdy we should revert the tween.js bump. Fortunately, @dmarcos did not bump his deps before he built the release so this only happens locally
does the CI not do npm install
? The older version of tween.js is deprecated; if the API change is trivial maybe we should just fix it.
It's deprecated, but it doesn't really hurt to keep the version we had previously and not add extra work / unexpectedness.
We have to manually build dists during release so the CI builds didn't make in
Is this something that would have been caught by unit tests? Does the CI system run the actual webGL code?
Everything is (still) working for me locally. 😕 Tests pass, npm start
works, demos work, all on a clean installation of aframe. I'm currently at @tweenjs/tween.js@16.10.0
. npm 4.6.1, node v6.9.5. Is it possible there was a bad patch release of tweenjs somewhere around the time we published? Or perhaps related to https://github.com/tweenjs/tween.js/issues/358?
I did a fresh checkout this morning and everything is fine. It must have been a transitory issue with TweenJS.
Sent from planet Earth
On Jul 22, 2017, at 11:52 AM, Don McCurdy notifications@github.com wrote:
Everything is (still) working for me locally. 😕 Tests pass, npm start works, demos work, all on a clean installation of aframe. I'm currently at @tweenjs/tween.js@16.10.0. npm 4.6.1, node v6.9.5. Is it possible there was a bad patch release of tweenjs somewhere around the time we published? Or perhaps related to tweenjs/tween.js#358?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
Good to hear! Thanks for checking again! I'll go ahead an close the issue and will reopen if necessary.
Description:
http://localhost:9000/examples/boilerplate/hello-world/
Do a clean checkout from HEAD, npm install, then npm run dev. The server will come up. Go to the hello-world demo. There is no graphics on screen. Look at the console. There are errors about Tween.js. Is the version of tween incorrect?