aframevr / aframe

:a: Web framework for building virtual reality experiences.
https://aframe.io/
MIT License
16.69k stars 3.98k forks source link

Oculus Browser perf regressions #4222

Closed dmarcos closed 4 years ago

dmarcos commented 5 years ago

It doesn’t seem A-Frame specific. I’ve seen several reports recently affecting all WebVR content (references below). @DigiTec @Artyom17 Any known bugs or regressions? Anything we should do on our side?

https://www.reddit.com/r/OculusQuest/comments/c6p3d5/jitter_judder_stutter_in_the_oculus_browser/?utm_source=share&utm_medium=ios_app

https://www.reddit.com/r/OculusQuest/comments/c8zet5/please_help_with_a_quick_oculus_quest_experiment/?utm_source=share&utm_medium=ios_app

https://github.com/supermedium/issues/issues/16

Galadirith commented 4 years ago

@Artyom17 Thanks so much again for working on these fixes. @kennardconsulting I reran the simple test cases with OB@7.0.6.184739535

I also tried several WebXR Samples and these did not have any apparent dropped framed when running those. I did try several other unpublished VR experiments I have locally. Most of the time performance was smooth. However very rarely (>> 10mins between instances) I did experience some jitter/judder. I didn't capture any statistics or have any recording of these. Based on the test cases I would be inclined to say that these apparent dropped frames would have been reflected in any captured statistics.

Overall I'm really happy with the updates. I appreciate (as @Artyom17 has suggested) there may well be some even more subtle issues/logic that lead to jitter (that may not be reflected in some statistics). However before these were quite common and made some apps feel close to unusable. Now it feels like native performance (even if it's not actually native performance 😊) which is more than enough for me.

I'm incredibly grateful for all the work from @Artyom17 on OB and @dmarcos on the AFrame side 😊 👍

dmarcos commented 4 years ago

@Galadirith thanks for the thorough testing

Galadirith commented 4 years ago

@dmarcos I believe there is nothing left to discuss, this issue has been resolved and I would be happy for this issue to be closed.

dmarcos commented 4 years ago

Thanks everybody that helped investigate and fix the issues