aframevr / aframe

:a: Web framework for building virtual reality experiences.
https://aframe.io/
MIT License
16.64k stars 3.96k forks source link

Docs: Search bar not working (no results for anything) #5322

Closed turbotimon closed 1 month ago

turbotimon commented 1 year ago

Description:

In the documentation the search bar does not show results for anything. This has been the case for at least a week and has been tested with several browsers:

image

dmarcos commented 1 year ago

Algolia integration is broken at the moment. Can use older versions search for now as a workaround https://aframe.io/docs/1.3.0/introduction/

Sorry for the inconvenience.

vincentfretin commented 1 year ago

This is also reported at:

msub2 commented 1 year ago

Is there anything we can do to help with this? Or is the Algolia integration something you're managing specifically

dmarcos commented 1 year ago

This is an algolia issue. algolia at some point deprecated the old API and moved to a new one. Indexation of new pages stopped. that's why search of old versions of a-frame still work. Any help appreciated but requires both work on the front end and Algolia side. Anyone can play with the site locally just by replacing the apiKey.

msub2 commented 1 year ago

Interesting, I'll see if I can take a look soon

dmarcos commented 1 year ago

In short if it was not clear. We need to move A-Frame website to the new Algolia API. The old one no longer indexes new pages. This is the file to look at first: https://github.com/aframevr/aframe-site/blob/master/themes/aframe/layout/partials/search.ejs

msub2 commented 1 year ago

It seems as though the new version of docsearch wants you to apply (and wants to verify you are the owner of the docs being indexed among other things) https://docsearch.algolia.com/apply/. Don't know if you've already seen this @dmarcos. Looks like under the hood it's using their Algolia Crawler which doesn't have the same restriction though.

lainshiHenry commented 1 year ago

It seems as though the new version of docsearch wants you to apply (and wants to verify you are the owner of the docs being indexed among other things) https://docsearch.algolia.com/apply/. Don't know if you've already seen this @dmarcos. Looks like under the hood it's using their Algolia Crawler which doesn't have the same restriction though.

As long as the owner enables permissions to update, that sound work too.

"You must be the owner of the website, or at least have the permissions to update its content." (https://docsearch.algolia.com/docs/who-can-apply)

dmarcos commented 1 year ago

You can develop locally with your own account and api key (free). I already did the application. Just haven’t had the time to migrate to the new API / infrastructure

dmarcos commented 1 month ago

This is fixed now. Thanks for the patience