Non Quest controllers don't work on Comicbook sample in vr mode

[idrisshah]

Comicbook sample does not work with any other controller in vr mode. The sample only works with Quest devices.

• A-Frame Version: 1.6.0
• Platform / Device: Magic Leap 2
• Reproducible Code Snippet or URL: https://aframe.io/aframe/examples/showcase/comicbook/

[idrisshah]

I created a pull request to make the input generic for the comicbook sample. Please review it. https://github.com/aframevr/aframe/pull/5579

[idrisshah]

Also this contribution is from Magic Leap with following legal statement:

Magic Leap, Inc. provides a copyright license to the aframevr/aframe [https://github.com/aframevr/aframe] maintainers for the materials accompanying this submission under the terms of the MIT license, recited below, with the understanding that the aframevr/aframe maintainers will then make the materials publicly available under the terms of the MIT license. For clarity, the materials are only licensed to the aframevr/aframe maintainers by this pull request and Magic Leap, Inc. retains all rights in the licensed content. Copyright (c) 2024 Magic Leap, Inc. Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

[dmarcos]

Thanks. Looked at the PR before this issue. Instead of using laser-controls you can add magicleap-controls to each hand entity as follows

<a-entity
   magicleap-controls="hand: left"
   oculus-touch-controls="hand: left" 
   page-controls>
</a-entity>

<a-entity
   magicleap-controls="hand: right"
   oculus-touch-controls="hand: right" 
   page-controls>
</a-entity>

Would that work? Thanks

[dmarcos]

Let me know if you have any questions