search

afranken / jmeter-analysis-maven-plugin

Plugin that parses JMeter result files and computes performance indicators such as average request duration
58 stars 40 forks source link

Execution does not finish correctly / System.out is closed #5

Closed malip closed 11 years ago

malip commented 11 years ago

The System.out is closed (by closing the PrintWritter) in "renderTextToStdOut()" function in AnalyzeCommand.java. The Writer should not be closed here. The maven execution is then not finished correctly and it causes problems in build tools (e.g. Jenkins). The patch is below. Anyway I think it should not print the result to stdout anyway (you have it in the file - no need to print it into maven output).

--- afranken-jmeter-analysis-maven-plugin-367a2db/src/main/java/com/lazerycode/jmeter/analyzer/AnalyzeCommand.java.orig 2012-09-25 16:48:32.541318349 +0200
+++ afranken-jmeter-analysis-maven-plugin-367a2db/src/main/java/com/lazerycode/jmeter/analyzer/AnalyzeCommand.java  2012-09-25 16:48:40.373318116 +0200
    @@ -147,7 +147,6 @@
     resultRenderHelper.renderText(testResults, out);

     out.flush();
-    out.close();
   }

//====================================================================================================================

ccancellieri commented 11 years ago

Have you planned a release including this fix?

afranken commented 11 years ago

yes, I just fixed this locally. Your pull request does not include this fix, BTW.