search

afranken / jmeter-analysis-maven-plugin

Plugin that parses JMeter result files and computes performance indicators such as average request duration
58 stars 40 forks source link

Gbatalski and Mine contrib #8

Closed ccancellieri closed 11 years ago

ccancellieri commented 11 years ago

This is a cumulative pull request fixing:

could you kindly merge and release it on the maven repository?

buildhive commented 11 years ago

Arne Franken » jmeter-analysis-maven-plugin #28 UNSTABLE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Arne Franken » jmeter-analysis-maven-plugin #29 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 11 years ago

Arne Franken » jmeter-analysis-maven-plugin #30 UNSTABLE Looks like there's a problem with this pull request (what's this?)

ccancellieri commented 11 years ago

mmm also seams that gbatalki introduced something making tests failure....

buildhive commented 11 years ago

Arne Franken » jmeter-analysis-maven-plugin #31 SUCCESS This pull request looks good (what's this?)

afranken commented 11 years ago

Hi, thanks, I'll take a look at the changes in the next few days. Cheers, Arne

ccancellieri commented 11 years ago

I hope so. Thanks, Carlo Cancellieri

afranken commented 11 years ago

well, it has been more than a few days, and I am finally looking at all the changes. I'll cherry-pick a few, but not all of them. Hopefully get all that done tomorrow.

afranken commented 11 years ago

first of all, thank you again for contributing to this open source project. Without users doing that, the code would never improve.

1) commit a617c3b -> won't merge. If you want the template to display the quantile in 5% steps, you can use custom templates. See property "templateDirectory"

2) commit 3d14c4e -> won't merge. With this commit, Samples collected from requests finishing with 0 milliseconds (I guess that won't happen often) will be counted with a minimum of Long.MAX_VALUE. Surely, nobody wants that.

3) commit 9ec7511 -> I'll merge parts of this, but I'll have to write additional (integration-)tests

4) commit d2a8a01 -> won't merge. Will add a Set property that defaults to "httpSample" and "sample". This is more flexible than adding a "don't use one of the possible names" property.

5) commit 0288ceb -> cherry-picked

6) commit b7e439d -> cherry-picked, see closed ticket

All following commits just fixed what commits a617c3b and 3d14c4e broke.

Cheers, Arne

afranken commented 11 years ago

see #10 for a continuation of commit 9ec7511 I have implemented it differently, though.