Closed ccancellieri closed 11 years ago
Arne Franken » jmeter-analysis-maven-plugin #28 UNSTABLE Looks like there's a problem with this pull request (what's this?)
Arne Franken » jmeter-analysis-maven-plugin #29 FAILURE Looks like there's a problem with this pull request (what's this?)
Arne Franken » jmeter-analysis-maven-plugin #30 UNSTABLE Looks like there's a problem with this pull request (what's this?)
mmm also seams that gbatalki introduced something making tests failure....
Arne Franken » jmeter-analysis-maven-plugin #31 SUCCESS This pull request looks good (what's this?)
Hi, thanks, I'll take a look at the changes in the next few days. Cheers, Arne
I hope so. Thanks, Carlo Cancellieri
well, it has been more than a few days, and I am finally looking at all the changes. I'll cherry-pick a few, but not all of them. Hopefully get all that done tomorrow.
first of all, thank you again for contributing to this open source project. Without users doing that, the code would never improve.
1) commit a617c3b -> won't merge. If you want the template to display the quantile in 5% steps, you can use custom templates. See property "templateDirectory"
2) commit 3d14c4e -> won't merge. With this commit, Samples collected from requests finishing with 0 milliseconds (I guess that won't happen often) will be counted with a minimum of Long.MAX_VALUE. Surely, nobody wants that.
3) commit 9ec7511 -> I'll merge parts of this, but I'll have to write additional (integration-)tests
4) commit d2a8a01
-> won't merge.
Will add a Set
5) commit 0288ceb -> cherry-picked
6) commit b7e439d -> cherry-picked, see closed ticket
All following commits just fixed what commits a617c3b and 3d14c4e broke.
Cheers, Arne
see #10 for a continuation of commit 9ec7511 I have implemented it differently, though.
This is a cumulative pull request fixing:
could you kindly merge and release it on the maven repository?