fooishbar
commented
6 years ago I think GBM format support would be more versatile if we used a separate gbm "family". This will allow us to get just GBM results when needed, e.g., "python3 -m pfg find-compatible VK_FORMAT_R8G8B8A8_UNORM gbm" will be able to return just the matching GBM formats which is not possible with the current proposal.
Since the GBM formats are guaranteed to just change the namespace of the DRM formats, one option would be for the implementation to forward requests (after amending the format string) to the DRM code. Also, it would be nice to have some tests. Using the drm test file as a starting point + the special cases would be sufficient.
Oh yeah, good points both! I'll revise it and submit a new version. Thanks :)
Hi, thanks for the patches! I have merged the wl_drm deprecation doc patch.
I think GBM format support would be more versatile if we used a separate gbm "family". This will allow us to get just GBM results when needed, e.g., "python3 -m pfg find-compatible VK_FORMAT_R8G8B8A8_UNORM gbm" will be able to return just the matching GBM formats which is not possible with the current proposal.
Since the GBM formats are guaranteed to just change the namespace of the DRM formats, one option would be for the implementation to forward requests (after amending the format string) to the DRM code. For testing, using the drm test file as a starting point + the special cases would be sufficient.