search

afreakyelf / Pdf-Viewer

A Lightweight PDF Viewer Android library which only occupies around 80kb while most of the Pdf viewer occupies up to 16MB space.
https://afreakyelf.github.io/Pdf-Viewer/
MIT License
692 stars 150 forks source link

Add compose Modifier parameter to PdfRendererViewCompose #102

Closed phucynwa closed 6 months ago

phucynwa commented 6 months ago

I tried to add the component PdfRendererViewCompose to my project using Jetpack Compose and it does not show in my case (I put it in a HorizontalPager). I rewrited it with a modifier parameter and it works like a charm.

So I think we should add modifier param to the component. It is also the best practice for every Compose components.