search

afreakyelf / Pdf-Viewer

A Lightweight PDF Viewer Android library which only occupies around 80kb while most of the Pdf viewer occupies up to 16MB space.
https://afreakyelf.github.io/Pdf-Viewer/
MIT License
769 stars 162 forks source link

Use internal storage and remove permissions for external storage #140

Open 4brunu opened 3 months ago

4brunu commented 3 months ago

Is your feature request related to a problem? Please describe. Currently when someone imports this library, it adds to the app the permissions for external storages. It would be nice to not impose this to the apps and remove those permissions.

Describe the solution you'd like This library should use internal storage and remove the external storage permissions.

github-actions[bot] commented 3 months ago

Thank you for creating your first issue. We appreciate your help in making this project better. We will look into it, and get back to you soon. Need help or want to discuss this issue? Join our Discord community here to ask questions and discuss this issue live!

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 2 months ago

This issue was closed because it has been stalled for 5 days with no activity.

4brunu commented 1 month ago

I asked to remove the external storage permission, because has a library this is integrated in a lot of apps, that want to make the permissions as minimal as possible, like mine. So it woulde be nice if we could remove this permission

afreakyelf commented 1 month ago

Someone raised the same concern some time back, so to tackle this and while supporting the older version, I added this to keep up with the latest guidelines. https://github.com/afreakyelf/Pdf-Viewer/blob/a2f11aa01fbfa4bdfaee5c7789c6504acb6c519f/pdfViewer/src/main/AndroidManifest.xml#L4-L5

4brunu commented 1 month ago

Removing the external storage permission, also has the side effect of removing some functionality of the library.

https://github.com/afreakyelf/Pdf-Viewer/blob/a2f11aa01fbfa4bdfaee5c7789c6504acb6c519f/pdfViewer/src/main/java/com/rajat/pdfviewer/PdfViewerActivity.kt#L428

afreakyelf commented 1 month ago

I believe its covered based on Android versions. https://github.com/afreakyelf/Pdf-Viewer/blob/a2f11aa01fbfa4bdfaee5c7789c6504acb6c519f/pdfViewer/src/main/java/com/rajat/pdfviewer/PdfViewerActivity.kt#L427-L447