search

afritz1 / OpenTESArena

Open-source re-implementation of The Elder Scrolls: Arena.
MIT License
988 stars 68 forks source link

Adding macOS to Travis CI #102

Closed Thunderforge closed 6 years ago

Thunderforge commented 6 years ago

Addresses #93.

Regarding multiple operating systems, I decided to follow the way that OpenMW does it by offloading the instructions to separate files, rather than the way from the Travis CI documentation, which will result in a messier build file.

All Mac and Linux builds passed when running against my local branch.

Thunderforge commented 6 years ago

By the way, the Mac builds use Homebrew, which is equivalent to apt-get. This does not require sudo access. The Travis documentation says that turning off sudo makes the Trusty builds go considerably faster.

The advantage of running with sudo: false is dramatically reduced time between commit push to GitHub and the start of a job on Travis CI, which works especially well when one’s average job duration is under 3 minutes.

I know that Linux build time isn't our bottleneck right now, but if we can run Linux without sudo, I think that it would be a good idea to do so, since the build time is indeed under 3 minutes.

afritz1 commented 6 years ago

Great! This gives us coverage on macOS compilers now. Putting the scripts in a CI folder was a good idea, too.

I think we left out sudo early on, but it was required for something, so we had to add it. I don't remember what it was, though.