search

afritz1 / OpenTESArena

Open-source re-implementation of The Elder Scrolls: Arena.
MIT License
1.01k stars 68 forks source link

Race descriptions are differently sized compared to vanilla #114

Open Thunderforge opened 6 years ago

Thunderforge commented 6 years ago

In vanilla, the race descriptions appear like this:

redguard vanilla

However in OpenTESArena, it appears like this:

reguard opentesarena

You'll notice that there is a lot more whitespace in the second picture than the first one, that it covers more of the map, and that the last line is considerably longer than the first.

This is the only description where I could tell a difference. All of the other descriptions (e.g. the player's class) appear to be the same size as vanilla.

afritz1 commented 6 years ago

I remember talking about this on Discord (Jan. 27th). Summarized for brevity:

Thunderforge: Quick question: are you looking for pixel-perfect compatibility in the menus? I noticed that the race description isn't the right size compared the the original

Me: OpenTESArena is currently displaying the texts as they are stored in the data, but I guess it needs to change to some max character limit per line at some point. It's not a bug; it's just another one of those quirks of Arena where it doesn't actually use the data as-is.

Thunderforge: Should I raise an issue on the GitHub page?

Me: whether or not you create an issue is fine. It's just low priority right now.

My thoughts haven't changed yet. I'm assuming Arena defines some integer for "max line width" somewhere, but I don't know anything more on the subject.

Thunderforge commented 6 years ago

Totally fine with it being low priority. I just realized today that I still had the screenshots around, but never got around to reporting it.

Carmina16 commented 6 years ago

This particular dialog is wrapped at 40 characters (the default value is 60).

afritz1 commented 6 years ago

This particular dialog is wrapped at 40 characters (the default value is 60).

Thanks. I will put this on the to-do list, along with the text box refactor and support for tab-specified colors.

afritz1 commented 6 years ago

Commit 02e2bb66723d92eea132470c7ff3dfd3ad9c8655 makes some progress on fixing this issue. It is almost there now, maybe one character off. I'm not exactly sure how the wrapping is done yet.