afritz1 / OpenTESArena

Open-source re-implementation of The Elder Scrolls: Arena.
MIT License
915 stars 68 forks source link

Adding additional error logs when renderer creation fails #240

Closed Thunderforge closed 1 year ago

Thunderforge commented 1 year ago

Adding calls to SDL_GetError() to logs for Renderer.cpp (previously it was present in some logs but not others).

Before

[Rendering/Renderer.cpp(191)] Warning: Failed to init accelerated SDL_Renderer, trying software fallback.
[Rendering/Renderer.cpp(197)] Error: Couldn't create software fallback SDL_Renderer.
[Rendering/Renderer.cpp(556)] Error: Couldn't create SDL_Renderer.

After

[Rendering/Renderer.cpp(192)] Warning: Failed to init accelerated SDL_Renderer, trying software fallback (error: No hardware accelerated renderers available).
[Rendering/Renderer.cpp(198)] Error: Couldn't create software fallback SDL_Renderer (error: Couldn't find matching render driver).
[Rendering/Renderer.cpp(557)] Error: Couldn't create SDL_Renderer (error: Couldn't find matching render driver).
afritz1 commented 1 year ago

I already added some in my fix for the Metal driver, all good, thanks! You're on the wrong branch I think.

Thunderforge commented 1 year ago

Looks like I posted this PR before you did yours, so it turned out to be redundant. Anyway, glad it got added.