search

afritz1 / OpenTESArena

Open-source re-implementation of The Elder Scrolls: Arena.
MIT License
988 stars 68 forks source link

CMake: Split the main CMakeLists.txt into separate files #36

Closed pcercuei closed 8 years ago

pcercuei commented 8 years ago

Plus some cleanups.

Signed-off-by: Paul Cercueil paul@crapouillou.net

afritz1 commented 8 years ago

In OpenTESArena/CMakeLists.txt, shouldn't the word TESArena be OpenTESArena? I'm not sure why it was shortened in the first place.

Ragora commented 8 years ago

I shortened it to prevent a naming clash with the OpenTESArena folder name as the result binary is being outputted to the same directory as the CMakeLists.txt right now and Linux binaries have no extension. It doesn't matter for any of the variable names that don't have the "Open" prefix, I just like to keep things consistent.

afritz1 commented 8 years ago

Okay. In release packages, though, I'd like the executable to use the full name.

Ragora commented 8 years ago

You'd have to change the folder name or change casing somewhere (which I personally wouldn't particularly like and is just awkward). At least, to just package it up the way it is like if you use this: https://cmake.org/Wiki/CMake:CPackPackageGenerators#DEB_.28UNIX_only.29

afritz1 commented 8 years ago

I mean for the .tar.gz release package that would just have the executable and other assorted files in it, so people are running OpenTESArena instead of TESArena. This wouldn't be a part of the build itself; just what people get at the end.

Ragora commented 8 years ago

The thing I linked would be a tool to generate those automatically (which also includes OSX App Bundles, RPM's and Debs) from the CMake projects. That's why I brought it up.

afritz1 commented 8 years ago

Oh, okay. We can use package creation tools at some point then.

Ragora commented 8 years ago

I haven't used CPack myself yet, I'm sure someone would have a better idea of its any good.