afrog33k / fog

Automatically exported from code.google.com/p/fog
0 stars 0 forks source link

A Patch for Image Codecs to compile under MingW64 GCC 4.6.2 #34

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This will fix compiler warning (errors in GCC) for JPEG and PNG codecs

Original issue reported on code.google.com by jay3dli...@gmail.com on 9 Oct 2011 at 8:15

Attachments:

GoogleCodeExporter commented 9 years ago
Hello,

thanks for the patch, I'm going to merge the boolean stuff, but I don't like 
the blitSpan() overload in ImageConverter. I need to investigate why it's 
required first, because in general, passing NULL here is not good idea.

Thanks
Petr

Original comment by kobalicek.petr on 9 Oct 2011 at 5:01

GoogleCodeExporter commented 9 years ago
Now I have it. It should be blitLine, I forget to rename that method.

I'm going to apply the boolean stuff, although, shouldn't it be compatible with 
the current "typedef int boolean" stuff declared by jpeg?

Original comment by kobalicek.petr on 9 Oct 2011 at 8:25

GoogleCodeExporter commented 9 years ago
Thanks for applying my patches :)

GCC is strict about typedef defined types, it's not just a substitution of words

Original comment by jay3dli...@gmail.com on 9 Oct 2011 at 8:59

GoogleCodeExporter commented 9 years ago
Boolean stuff applied, blitSpan fixed

Thank you for the patch, marking as fixed.
Petr

Original comment by kobalicek.petr on 10 Oct 2011 at 7:32