ExpandVar doesn't print the input file name

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Run gyp -f make -DOS=freebsd build/all.gyp
2. (Don't) see the failing gyp file

Here's the output before the patch:

: flz@mayday:/home/flz/home/chrome-svn/tarball/chromium/src; ./tools/gyp/gyp -f 
make -
DOS=freebsd build/all.gyp
Traceback (most recent call last):
  File "./tools/gyp/gyp", line 14, in <module>
    sys.exit(gyp.main(sys.argv[1:]))
  File "./tools/gyp/pylib/gyp/__init__.py", line 228, in main
    includes, options.depth)
  File "./tools/gyp/pylib/gyp/__init__.py", line 61, in Load
    depth, generator_input_info)
  File "./tools/gyp/pylib/gyp/input.py", line 1573, in Load
    LoadTargetBuildFile(build_file, data, aux_data, variables, includes, depth)
  File "./tools/gyp/pylib/gyp/input.py", line 281, in LoadTargetBuildFile
    includes, depth)
  File "./tools/gyp/pylib/gyp/input.py", line 281, in LoadTargetBuildFile
    includes, depth)
  File "./tools/gyp/pylib/gyp/input.py", line 281, in LoadTargetBuildFile
    includes, depth)
  File "./tools/gyp/pylib/gyp/input.py", line 244, in LoadTargetBuildFile
    build_file_path)
  File "./tools/gyp/pylib/gyp/input.py", line 620, in ProcessVariablesAndConditionsInDict
    build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 636, in ProcessVariablesAndConditionsInList
    build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 620, in ProcessVariablesAndConditionsInDict
    build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 636, in ProcessVariablesAndConditionsInList
    build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 620, in ProcessVariablesAndConditionsInDict
    build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 640, in ProcessVariablesAndConditionsInList
    expanded = ExpandVariables(item, is_late, variables, build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 356, in ExpandVariables
    ' in ' + input
KeyError: 'Undefined variable source_files in <@(source_files)'

Here's the output after the patch:

: flz@mayday:/home/flz/home/chrome-svn/tarball/chromium/src; ./tools/gyp/gyp -f 
make -
DOS=freebsd build/all.gyp
Traceback (most recent call last):
  File "./tools/gyp/gyp", line 14, in <module>
    sys.exit(gyp.main(sys.argv[1:]))
  File "./tools/gyp/pylib/gyp/__init__.py", line 228, in main
    includes, options.depth)
  File "./tools/gyp/pylib/gyp/__init__.py", line 61, in Load
    depth, generator_input_info)
  File "./tools/gyp/pylib/gyp/input.py", line 1573, in Load
    LoadTargetBuildFile(build_file, data, aux_data, variables, includes, depth)
  File "./tools/gyp/pylib/gyp/input.py", line 281, in LoadTargetBuildFile
    includes, depth)
  File "./tools/gyp/pylib/gyp/input.py", line 281, in LoadTargetBuildFile
    includes, depth)
  File "./tools/gyp/pylib/gyp/input.py", line 281, in LoadTargetBuildFile
    includes, depth)
  File "./tools/gyp/pylib/gyp/input.py", line 244, in LoadTargetBuildFile
    build_file_path)
  File "./tools/gyp/pylib/gyp/input.py", line 620, in ProcessVariablesAndConditionsInDict
    build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 636, in ProcessVariablesAndConditionsInList
    build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 620, in ProcessVariablesAndConditionsInDict
    build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 636, in ProcessVariablesAndConditionsInList
    build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 620, in ProcessVariablesAndConditionsInDict
    build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 640, in ProcessVariablesAndConditionsInList
    expanded = ExpandVariables(item, is_late, variables, build_file)
  File "./tools/gyp/pylib/gyp/input.py", line 356, in ExpandVariables
    ' in ' + build_file
KeyError: 'Undefined variable source_files in /usr/home/flz/home/chrome-
svn/tarball/chromium/src/third_party/ffmpeg/ffmpeg.gyp'

Original issue reported on code.google.com by florent....@gmail.com on 9 Jul 2009 at 8:05

Attachments:

• gyp-expandvar.diff

[GoogleCodeExporter]

This was committed by mark@ in r542.

Original comment by florent....@gmail.com on 15 Jul 2009 at 2:17

[GoogleCodeExporter]

sgk to integrate.

Original comment by sgk@chromium.org on 6 Aug 2009 at 6:43

• Changed state: Started
• Added labels: Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

As the previous comment says, integrated in r542.  sgk to learn to read all the 
comments first...

Original comment by sgk@chromium.org on 14 Aug 2009 at 5:28

• Changed state: Fixed