search

afrolov / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Expand variables in includes paths #72

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Add a variable reference into one of the paths inside the 'includes' list of 
a gyp file. 
2. Run gyp on the file.

What is the expected output? What do you see instead?
gyp should resolve the variable, if the variable is specified in the gyp 
command line.

Original issue reported on code.google.com by y...@chromium.org on 1 Sep 2009 at 10:41

GoogleCodeExporter commented 9 years ago 
The attached patch will expand variables in the includes paths. At that stage 
of the 
evaluation, only environment and command line variables are available, which is 
ok.

Original comment by y...@chromium.org on 1 Sep 2009 at 10:42

Attachments:

GoogleCodeExporter commented 9 years ago 
Patch looks good, should add it.  Needs a test case.

Original comment by sgk@chromium.org on 21 Oct 2009 at 5:49

GoogleCodeExporter commented 9 years ago 
The patch actually breaks some existing tests. We have a workaround in 
chromium, so 
this is not required any more.

Original comment by y...@chromium.org on 21 Oct 2009 at 6:17