afrunt / jach

Java library for reading and writing ACH/NACHA documents
Apache License 2.0
44 stars 37 forks source link

ACH Reader isn't respecting the mandatory fields in entry detail #19

Open Jawwad124 opened 4 years ago

Jawwad124 commented 4 years ago

I have been trying to read a file which has an entry detail with mandatory transaction code missing from it. E.g :

6 111222334112233445588 0000003598 Jackson Bird 1111111110000607

Here after first 6 transaction code is missing but this file get passed from ACH Reader validation. As far i remember on 0.2.5.x this wasn't an issue. I have tried with all 0.3.x version and no one fails the file due to missing mandatory field. I suspect validation is broken in other places as well.

I haven't got the chance to look into the details yet but this seems to be an important issue hence raising it.

afrunt commented 4 years ago

@Jawwad124 as far as I remember there is no validation within reader

Jawwad124 commented 4 years ago

Right :(

Could this be easily integrated into the flow. We don't just generate the file, we also process its Return. If any thing is messed up in return file data. We won't get to know.

Its kind of a useful feature as well.