BatchControl/BatchHeader inconsistency

afrunt / jach

Java library for reading and writing ACH/NACHA documents

Apache License 2.0

44 stars 36 forks source link

BatchControl/BatchHeader inconsistency #27

Closed halytskyiv closed 3 years ago

halytskyiv commented 3 years ago

I want to say thank you for putting this project on the internet. it is a great timesaver for software engineers around the world.

I have two questions, related to the project:

Why serviceSlassCode in BatchHeader.java is String, but in BatchControl.java it is Integer?
Looks like companyIdentification in BatchControl.java and companyID in GeneralBatchHeader.java are the same value, but why they are named differently?

Thank you very much!

afrunt commented 3 years ago

@halytskyiv to be honest, I didn't create this inconsistency by myself. All those types and fields are from nacha spec and I agree, that sometimes they could look weird ¯_(ツ)_/¯

halytskyiv commented 3 years ago

@afrunt Thank you for a quick response