Quick Notes - Githubissues

afry-south / semantic-poc

End-to-end proof-of-concept of a semantic search engine with elastic search and huggingface.

1 stars 0 forks source link

Open Lundez opened 2 years ago

Lundez commented 2 years ago

We should prefer to be PEP compliant and use pythonic standard.

Prefer List Comprehension over Map
Methods defined outside of scope of main-function unless very small (e.g. nearly a lambda)
Add type-hints (this is really helpful)

Confusion moments:

Lundez commented 2 years ago

Other good things,