afsc-assessments / SurveyAverageRandomEffects

2 stars 1 forks source link

What are all these models? #2

Open Cole-Monnahan-NOAA opened 4 years ago

Cole-Monnahan-NOAA commented 4 years ago

So I wrote some functions around the output of the RE model that I got from somewhere (where???) and am just noticing that it is different than what is currently in the src file of this repo (i.e., re.tpl). Furthermore there are rw.tpl, ln_rw.tpl, rwa.tpl.

I diff'd them and it looks like rw.tpl is not working in log space. ln_rw.tpl is different from rw.tpl in that it uses log, but also the parameterization and reporting and it doesn't use SEPARABLE functions. rwa.tpl is a different version. The last two say " // random walk model to test simulations from Paul Spencer" at the top.

What are these doing in the repo? Which should we use? What is the official version? Why do I have a different version than is presented here?

My understanding of this repo is that it should contain the RE model used by assessment authors. If that's true, then I vote to delete all these old/unused files, nominate a current version, and maintain a clean, transparent repo and ensure that everyone is using the official version of the software.

jimianelli commented 4 years ago

yea, RE has never been cleaned up and git-released, thanks for doing that and making the recommendations!

On Tue, Aug 25, 2020 at 3:00 PM Cole Monnahan notifications@github.com wrote:

So I wrote some functions around the output of the RE model that I got from somewhere (where???) and am just noticing that it is different than what is currently in the src file of this repo (i.e., re.tpl). Furthermore there are rw.tpl, ln_rw.tpl, rwa.tpl.

I diff'd them and it looks like rw.tpl is not working in log space. ln_rw.tpl is different from rw.tpl in that it uses log, but also the parameterization and reporting and it doesn't use SEPARABLE functions. rwa.tpl is a different version. The last two say " // random walk model to test simulations from Paul Spencer" at the top.

What are these doing in the repo? Which should we use? What is the official version? Why do I have a different version than is presented here?

My understanding of this repo is that it should contain the RE model used by assessment authors. If that's true, then I vote to delete all these old/unused files, nominate a current version, and maintain a clean, transparent repo and ensure that everyone is using the official version of the software.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/afsc-assessments/SurveyAverageRandomEffects/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUW7YVA57IUTPTPWXHQ42DSCQYBFANCNFSM4QLEC3RA .

-- Jim Ianelli